Skip to content

strengthen assignment type consistency #3660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Conversation

kroening
Copy link
Member

@kroening kroening commented Jan 3, 2019

The previous check for type consistency of assignments uses base_type_eq,
which permits the expansion of tag types. This expansion makes dealing with
such types prone to error and costs memory and performance.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The previous check for type consistency of assignments uses base_type_eq,
which permits the expansion of tag types.  This expansion makes dealing with
such types prone to error and costs memory and performance.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: caae4ce).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96198303

@kroening kroening merged commit dac8c7b into develop Jan 3, 2019
@kroening kroening deleted the assignment-type-equality branch January 3, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants