Skip to content

smt2: let fix #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2019
Merged

smt2: let fix #3654

merged 2 commits into from
Jan 2, 2019

Conversation

kroening
Copy link
Member

@kroening kroening commented Dec 31, 2018 •
edited
Loading

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening changed the title Smt2 let fix smt2: let fix Dec 31, 2018
allredj
allredj reviewed Dec 31, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: b5ee26b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96005560

@kroening kroening mentioned this pull request Jan 1, 2019
Closed
7 tasks
tautschnig
tautschnig reviewed Jan 1, 2019
View reviewed changes
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing commit messages and tests?

Daniel Kroening added 2 commits January 2, 2019 11:53
smt2: add a missing space
eae5bca
smt2 frontend: let identifiers must be globally unique
aae639a 
The solver backend assumes that identifiers used in let expressions are
globally unique.  The renamed identifiers are now retained in the id_map to
ensure that they are not re-used.

This enables 11 regression tests to pass.
@kroening
Copy link
Member Author

kroening commented Jan 2, 2019

@tautschnig Apologies, now both there!

allredj
allredj reviewed Jan 2, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: aae639a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96066022

@tautschnig tautschnig merged commit 2be3344 into develop Jan 2, 2019
@tautschnig tautschnig deleted the smt2-let-fix branch January 2, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tautschnig tautschnig tautschnig left review comments

@allredj allredj allredj approved these changes

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@romainbrenguier romainbrenguier Awaiting requested review from romainbrenguier

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kroening @tautschnig @allredj