CL message handler #3637
Merged
CL message handler #3637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tautschnig
commented
Dec 28, 2018
tautschnig
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
tautschnig
requested review from
chrisr-diffblue,
kroening,
peterschrammel,
pkesseli and
smowton
as code owners
3 tasks
kroening
approved these changes
Dec 29, 2018
tautschnig
force-pushed
the
cl-message-handler
branch
from
6e9d587 to
6a2c0f7
Compare
tautschnig
force-pushed
the
cl-message-handler
branch
from
6a2c0f7 to
007aa06
Compare
smowton
approved these changes
Jan 2, 2019
tautschnig
force-pushed
the
cl-message-handler
branch
4 times, most recently
from
ab19809 to
a3ab033
Compare
tautschnig
force-pushed
the
cl-message-handler
branch
from
a3ab033 to
6d7c310
Compare
The only use is within goto-cc, there is no need to define this in util/.
These files have been moved and should now conform with our coding guidelines.
tautschnig
force-pushed
the
cl-message-handler
branch
from
6d7c310 to
0fcf5a1
Compare
allredj
reviewed
Jan 3, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 0fcf5a1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96164783
tautschnig
force-pushed
the
cl-message-handler
branch
from
0fcf5a1 to
905e5ed
Compare
console_message_handlert does not print source lines, which we do in GCC mode and should also be doing in CL mode.
The third line holds command-line options.
tautschnig
force-pushed
the
cl-message-handler
branch
from
905e5ed to
8edd464
Compare
allredj
reviewed
Jan 3, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 8edd464).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96179689
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.