Skip to content

Make Powershell stop on errors [depends-on: #3616, blocks: #2310, #3636, #3637] #3627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Make Powershell stop on errors [depends-on: #3616, blocks: #2310, #3636, #3637] #3627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions buildspec-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ phases:
- |
$env:Path = "C:\tools\cygwin\bin;$env:Path"
cmd /c 'call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" x64 && bash -c "make -C regression test BUILD_ENV=MSVC" '

- |
Copy link
Contributor

@chrisr-diffblue chrisr-diffblue Jan 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies if I don't understand the buildspec + windows combination - but why does regression/goto-cl need to be treated any differently from any of the other subdirectories in regression/ ?

Copy link
Contributor

@smowton smowton Jan 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's just that goto-cl is not part of the standard make test target set. Perhaps we should make it so under win32, either by checking $OS or by checking if cl.exe appears to be in the path using which.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing up the make test target to understand that on win32 or whatever, extra targets should be added would probably be preferable/less error prone when moving between CI infrastructure, etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take care of this in a separate PR. We also have some weird interaction between scripts removing dirs and the makefiles at the moment, which should all go away thanks to the -X/-I options in test.pl.

$env:Path = "C:\tools\cygwin\bin;$env:Path"
cmd /c 'call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" x64 && bash -c "make -C regression/goto-cl test BUILD_ENV=MSVC" '

- |
Expand Down