irept-related fixes [blocks: #2035] #3606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a1c6e54 uses std::map, but the header was only provided through irep.h, which might not do so in case SUB_IS_LIST is in effect.
In 48c40db the *2 got lost, and previously it already was off-by-one, all of which result in unnecessary re-allocations.
This returned the wrong value in case sub/named_sub had mismatching size. It really was wrong ever since committed to the repository, proving that the code never was used. It should likely just be removed.
There is no need to create a copy at this point.
tautschnig
requested review from
kroening,
peterschrammel,
pkesseli and
smowton
as code owners
|
The |
As said in the commit message, I think we should really just remove this code. |
allredj
reviewed
Dec 20, 2018
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: d4649bc).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/95401102
smowton
approved these changes
Dec 20, 2018
tautschnig
added a commit
that referenced
this pull request
Dec 20, 2018
irept: Use singly-linked lists with SUB_IS_LIST [depends on: #3606]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four independent smaller fixes all triggered by reviewing code around irept/SUB_IS_LIST-related changes.