Add rvalue constructor to xmlt #3600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue,
kroening,
martin-cs,
peterschrammel,
pkesseli,
smowton and
thk123
as code owners
kroening
reviewed
Dec 19, 2018
| @@ -27,6 +27,13 @@ class xmlt | |||
| typedef std::list<xmlt> elementst; | |||
| typedef std::map<std::string, std::string> attributest; | |||
|
|
|||
| xmlt(std::string _name, attributest &&_attributes, elementst &&_elements) | |||
| : name(std::move(_name)), | |||
There was a problem hiding this comment.
I was wondering how well that would work given the common case is a C string at that point. Or maybe it actually makes no difference?
There was a problem hiding this comment.
std::string has a lot of optimisation behind it (I've seen instances with copy-on-write, short-string stored in the class itself, etc.); however, disregarding this, yes, it should.
There was a problem hiding this comment.
I've now added the &&.
tautschnig
force-pushed
the
xml-raii
branch
2 times, most recently
from
0cd7c02 to
9f96fc4
Compare
This enables RAII and a more concise notation.
tautschnig
assigned smowton, kroening, peterschrammel and chrisr-diffblue and unassigned tautschnig
allredj
reviewed
Dec 19, 2018
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 61f23cc).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/95336005
smowton
approved these changes
Dec 20, 2018
| xmlt edge2("edge"); | ||
| edge2.set_attribute("source", graphml[from].node_name); | ||
| edge2.set_attribute("target", graphml[sink].node_name); | ||
| xmlt edge2("edge", { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables RAII and a more concise notation.