Skip to content

Unit test of byte operator lowering [blocks: #2068] #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2019

Conversation

tautschnig
Copy link
Collaborator

Only the last commit is new, and also work-in-progress as I want to add more test cases.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig changed the title Unit test of byte operator lowering [depends on: #3591, #3592, #3596, blocks: #2058] Unit test of byte operator lowering [depends on: #3592, blocks: #2058] Dec 18, 2018
@tautschnig tautschnig changed the title Unit test of byte operator lowering [depends on: #3592, blocks: #2058] Unit test of byte operator lowering [blocks: #2058] Dec 19, 2018
@tautschnig tautschnig self-assigned this Dec 19, 2018
@tautschnig tautschnig changed the title Unit test of byte operator lowering [blocks: #2058] Unit test of byte operator lowering [blocks: #2068] Dec 19, 2018
@tautschnig tautschnig force-pushed the byte-op-unit-test branch 3 times, most recently from f0eb832 to fac56f5 Compare December 28, 2018 20:46
tautschnig added a commit that referenced this pull request Jan 21, 2019
Add initializer list constructor to struct/union typet and cleanup API use [blocks: #3597]
@tautschnig tautschnig force-pushed the byte-op-unit-test branch 2 times, most recently from 1cae627 to a6b6756 Compare January 31, 2019 23:44
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: fd81e72).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99364877

We can safely generate these from bits strings.
We can safely generate strings from (constant) expressions of those kinds.
The test attempts to systematically explore combinations of types, and shows a
number of current bugs or limitations.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 1bba22f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99389674

@tautschnig tautschnig merged commit 3d372e2 into diffblue:develop Feb 1, 2019
@tautschnig tautschnig deleted the byte-op-unit-test branch February 1, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants