Make __CPROVER_allocated_memory work with non-POD type objects #3595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue,
martin-cs,
peterschrammel,
smowton and
thk123
as code owners
tautschnig
force-pushed
the
allocated
branch
from
c9d0774 to
cc9e551
Compare
allredj
reviewed
Dec 18, 2018
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: cc9e551).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/95163014
smowton
reviewed
Dec 19, 2018
src/analyses/goto_check.cpp
Outdated
| @@ -1017,14 +1017,14 @@ goto_checkt::address_check(const exprt &address, const exprt &size) | |||
| if(flags.is_unknown() || flags.is_dynamic_heap()) | |||
| { | |||
| conditions.push_back(conditiont( | |||
| not_exprt(deallocated(address, ns)), | |||
| or_exprt(allocs, not_exprt(deallocated(address, ns))), | |||
There was a problem hiding this comment.
allocs seems like it should be a list of allocations, not a boolean, how about renaming it in_bounds_of_some_alloc?
There was a problem hiding this comment.
I've added a second commit doing the suggested renaming, thanks!
allredj
approved these changes
Dec 19, 2018
The precision of local_bitvector_analysist is not sufficient to rule out several cases introduced in 732ce2a.
This is a Boolean expressions, and the name should convey this.
tautschnig
force-pushed
the
allocated
branch
from
cc9e551 to
8eac552
Compare
smowton
approved these changes
Dec 19, 2018
peterschrammel
approved these changes
Dec 19, 2018
allredj
reviewed
Dec 19, 2018
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 8eac552).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/95246160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The precision of local_bitvector_analysist is not sufficient to rule out several
cases introduced in 732ce2a.