Skip to content

Move BMC options and help text to bmc_util [depends: 3565] #3581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

peterschrammel
Copy link
Member

Based on #3565, review only last commit

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: bb31b47).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/94899676
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@@ -53,6 +53,8 @@ Author: Daniel Kroening, [email protected]

#include <langapi/mode.h>

#include <cbmc/bmc.h> // will go away
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding an issue or are you tracking this in some way?

Copy link
Member Author

@peterschrammel peterschrammel Dec 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be the result as soon as I reach the top of this DAG of PRs.

@tautschnig
Copy link
Collaborator

Marking do-not-merge until depended-on PR is merged.

@peterschrammel
Copy link
Member Author

Marking do-not-merge until depended-on PR is merged.

Can we assume that "dependent" implies "do not merge" to reduce the number of labels?
Or rename "dependent" to "dependent - do not merge".

@tautschnig
Copy link
Collaborator

Or rename "dependent" to "dependent - do not merge".

+1 on this - I'd like to avoid implicit information.

Then it can be used by any driver using BMC.
@peterschrammel peterschrammel merged commit 928a6d8 into diffblue:develop Jan 9, 2019
@peterschrammel peterschrammel deleted the move-bmc-options branch January 9, 2019 17:17
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 8d150f0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96787768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants