-
Notifications
You must be signed in to change notification settings - Fork 274
Move BMC options and help text to bmc_util [depends: 3565] #3581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move BMC options and help text to bmc_util [depends: 3565] #3581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: bb31b47).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/94899676
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
@@ -53,6 +53,8 @@ Author: Daniel Kroening, [email protected] | |||
|
|||
#include <langapi/mode.h> | |||
|
|||
#include <cbmc/bmc.h> // will go away |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding an issue or are you tracking this in some way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will be the result as soon as I reach the top of this DAG of PRs.
Marking do-not-merge until depended-on PR is merged. |
Can we assume that "dependent" implies "do not merge" to reduce the number of labels? |
+1 on this - I'd like to avoid implicit information. |
Then it can be used by any driver using BMC.
bb31b47
to
8d150f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 8d150f0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96787768
Based on #3565, review only last commit