Skip to content

Move symex-bmc and symex-coverage to goto-checker [blocks: 3583] #3580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2019

Conversation

peterschrammel
Copy link
Member

@peterschrammel peterschrammel commented Dec 16, 2018

Based on #3565, review only last two commits

  • Each commit message has a non-empty body, explaining why the change was made.
  • [n/a] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [n/a] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • [n/a] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [n/a] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@peterschrammel peterschrammel changed the title Move symex-bmc and symex-coverage to goto-checker [depends: 3565] Move symex-bmc and symex-coverage to goto-checker [depends: 3565, blocks: 3583] Dec 16, 2018
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 0205d09).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/94908846
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but see also my comment on the other PR: these parts may be language-independent, but they are very much tied to bounded model checking. I'm wondering whether we need a "bmc" folder.

@tautschnig
Copy link
Collaborator

Marking do-not-merge until depended-on PRs are merged.

@peterschrammel
Copy link
Member Author

peterschrammel commented Jan 9, 2019

I'm wondering whether we need a "bmc" folder.

I think it's exaggerated to split out bmc into yet another module at this point. I'll put this down as an improvement suggestion for a later stage.

@tautschnig tautschnig changed the title Move symex-bmc and symex-coverage to goto-checker [depends: 3565, blocks: 3583] Move symex-bmc and symex-coverage to goto-checker [blocks: 3583] Jan 9, 2019
@peterschrammel peterschrammel merged commit f8991d9 into diffblue:develop Jan 9, 2019
@peterschrammel peterschrammel deleted the move-symex-bmc branch January 9, 2019 15:55
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 7815d68).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96775271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants