-
Notifications
You must be signed in to change notification settings - Fork 274
Move symex-bmc and symex-coverage to goto-checker [blocks: 3583] #3580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move symex-bmc and symex-coverage to goto-checker [blocks: 3583] #3580
Conversation
31defce
to
4b4d566
Compare
4b4d566
to
0205d09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 0205d09).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/94908846
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but see also my comment on the other PR: these parts may be language-independent, but they are very much tied to bounded model checking. I'm wondering whether we need a "bmc" folder.
Marking do-not-merge until depended-on PRs are merged. |
I think it's exaggerated to split out bmc into yet another module at this point. I'll put this down as an improvement suggestion for a later stage. |
0205d09
to
c7aebc0
Compare
These classes are language-independent.
c7aebc0
to
7815d68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 7815d68).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96775271
Based on #3565, review only last two commits