Skip to content

Add witness output to goto checker [blocks: 3583] #3579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2019
Merged

Add witness output to goto checker [blocks: 3583] #3579

merged 1 commit into from
Jan 13, 2019

Conversation

peterschrammel
Copy link
Member

@peterschrammel peterschrammel commented Dec 16, 2018 •
edited
Loading

Based on #3564, only review last commit

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@peterschrammel peterschrammel force-pushed the goto-checker-witness-output branch from 27a0d84 to 2107223 Compare December 16, 2018 17:14
allredj
allredj reviewed Dec 16, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 2107223).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/94898955
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@peterschrammel peterschrammel mentioned this pull request Dec 16, 2018
Merged
5 tasks
@peterschrammel peterschrammel changed the title Add witness output to goto checker [depends: 3564] Add witness output to goto checker [depends: 3564, blocks: 3583] Dec 16, 2018
tautschnig
tautschnig approved these changes Dec 17, 2018
View reviewed changes
src/goto-checker/goto_checker.h Outdated
@@ -59,6 +59,11 @@ class goto_checkert
/// This builds and returns the counterexample
virtual goto_tracet build_error_trace() const = 0;

/// This outputs an error witness
virtual void output_error_witness(const goto_tracet &) = 0;
/// This outputs an proof
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have (wrongly) commented on this commit elsewhere: s/an/a/

smowton
smowton approved these changes Dec 17, 2018
View reviewed changes
src/goto-checker/goto_checker.h Outdated
@@ -59,6 +59,11 @@ class goto_checkert
/// This builds and returns the counterexample
virtual goto_tracet build_error_trace() const = 0;

/// This outputs an error witness
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop Doxy comments that just repeat the function name? Or, provide a link to define witness?

@peterschrammel peterschrammel changed the title Add witness output to goto checker [depends: 3564, blocks: 3583] Add witness output to goto checker [blocks: 3583] Jan 13, 2019
@peterschrammel peterschrammel force-pushed the goto-checker-witness-output branch from 2107223 to db83fce Compare January 13, 2019 13:38
@peterschrammel peterschrammel merged commit 1865865 into diffblue:develop Jan 13, 2019
@peterschrammel peterschrammel deleted the goto-checker-witness-output branch January 13, 2019 14:59
allredj
allredj reviewed Jan 13, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: db83fce).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97163305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@tautschnig tautschnig tautschnig approved these changes

@cesaro cesaro Awaiting requested review from cesaro

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@cristina-david cristina-david Awaiting requested review from cristina-david

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

Assignees

@peterschrammel peterschrammel

Labels
blocker Goto-checker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterschrammel @smowton @tautschnig @allredj