Multi-operand constructor for code_ifthenelset #3504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
cesaro,
cristina-david,
kroening,
NathanJPhillips,
peterschrammel,
pkesseli,
smowton and
thk123
as code owners
kroening
approved these changes
Dec 2, 2018
tautschnig
force-pushed
the
constructors-ifthenelse
branch
from
c895f23 to
19ba986
Compare
tautschnig
requested review from
chrisr-diffblue and
martin-cs
as code owners
tautschnig
force-pushed
the
constructors-ifthenelse
branch
from
19ba986 to
967a422
Compare
allredj
reviewed
Dec 2, 2018
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 967a422).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/93291442
smowton
approved these changes
Dec 3, 2018
| function_body.add(conditional); | ||
| const code_ifthenelset conditional( | ||
| init_complete.symbol_expr(), code_returnt()); | ||
| function_body.add(std::move(conditional)); |
There was a problem hiding this comment.
No need for the temporary conditional any longer?
There was a problem hiding this comment.
True, but I still left it in place as the line otherwise got long-ish. But if anyone thinks it should rather be removed then I'll happily do so.
There was a problem hiding this comment.
BTW, the combination of 'const' and std::move won't do anything.
tautschnig
force-pushed
the
constructors-ifthenelse
branch
from
967a422 to
371c809
Compare
This enables RAII rather then incremental construction.
tautschnig
force-pushed
the
constructors-ifthenelse
branch
from
371c809 to
8427934
Compare
allredj
reviewed
Dec 17, 2018
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 8427934).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/94994551
peterschrammel
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables RAII rather then incremental construction.