Skip to content

Remove deprecated exprt::make_true #3490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

tautschnig
Copy link
Collaborator

All users should use true_exprt() instead.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: f56ea05).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/93252762
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@tautschnig
Copy link
Collaborator Author

@peterschrammel @thk123 @allredj This might require genuine changes in TG. Maybe those can just be done as make_true is deprecated and should thus not have a place in TG?

All users should use true_exprt() instead.
@thk123
Copy link
Contributor

thk123 commented Dec 3, 2018

Yeah this needs a real bump bump - will create later today

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: d33be42).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/93346369
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@LAJW
Copy link
Contributor

LAJW commented Dec 3, 2018

Passing Test-gen update PR: https://github.com/diffblue/test-gen/pull/2526

@tautschnig
Copy link
Collaborator Author

Do you want to merge changes in TG before this one is merged, or is this one ok to merge?

@smowton smowton merged commit 8c16edb into diffblue:develop Dec 4, 2018
@smowton
Copy link
Contributor

smowton commented Dec 4, 2018

(it's ok to merge cbmc first)

@tautschnig tautschnig deleted the no-make_true branch December 4, 2018 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants