Skip to content

Make validation mode parameter explicit in DATA_CHECK macros [blocks #3287] #3480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

danpoe
Copy link
Contributor

@danpoe danpoe commented Nov 29, 2018

As requested by @tautschnig in a comment to an earlier PR, this makes the validation mode an explicit parameter of the DATA_CHECK() macros.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@danpoe danpoe force-pushed the refactor/make-validation-mode-explicit-argument branch 2 times, most recently from ddfa911 to be9f1a9 Compare November 29, 2018 15:33
@chrisr-diffblue chrisr-diffblue changed the title Make validation mode parameter explicit in DATA_CHECK macros Make validation mode parameter explicit in DATA_CHECK macros [blocks #3287] Nov 29, 2018
@danpoe danpoe force-pushed the refactor/make-validation-mode-explicit-argument branch from be9f1a9 to 76f0ec7 Compare November 29, 2018 15:54
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 76f0ec7).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/93038258

Copy link
Contributor

@xbauch xbauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is well done, prefer the explicit passing of it around to the assumption that a vm variable should be in scope.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tautschnig tautschnig merged commit e62a14c into diffblue:develop Dec 1, 2018
tautschnig added a commit that referenced this pull request Dec 1, 2018
Well-formedness checking of SSA equation [depends on #3480]
@danpoe danpoe deleted the refactor/make-validation-mode-explicit-argument branch June 2, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants