-
Notifications
You must be signed in to change notification settings - Fork 273
Make validation mode parameter explicit in DATA_CHECK macros [blocks #3287] #3480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make validation mode parameter explicit in DATA_CHECK macros [blocks #3287] #3480
Conversation
ddfa911
to
be9f1a9
Compare
be9f1a9
to
76f0ec7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 76f0ec7).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/93038258
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is well done, prefer the explicit passing of it around to the assumption that a vm
variable should be in scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Well-formedness checking of SSA equation [depends on #3480]
As requested by @tautschnig in a comment to an earlier PR, this makes the validation mode an explicit parameter of the
DATA_CHECK()
macros.