Skip to content

Document the flag needed for function names in stack backtraces. #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

martin-cs
Copy link
Collaborator

@martin-cs martin-cs commented Nov 28, 2018

Glibc and Apple's libc both provide support for stack introspection.
This is used by the invariant code to generate a stack backtrace
on invariant failure. By default GCC strips out the function names
so an additional LINKFLAG is needed to get function names in the
backtrace. This was hidden^Wdocumented in util/invariant.cpp, this
patch adds it to config.inc so it can be more widely understood
and used.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Glibc and Apple's libc both provide support for stack introspection.
This is used by the invariant code to generate a stack backtrace
on invariant failure.  By default GCC strips out the function names
so an additional LINKFLAG is needed to get function names in the
backtrace.  This was hidden^Wdocumented in util/invariant.cpp, this
patch adds it to config.inc so it can be more widely understood
and used.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 57e8cc6).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/92861207

@tautschnig tautschnig merged commit aec39d5 into diffblue:develop Nov 28, 2018
@martin-cs martin-cs deleted the fix/document-backtrace-option-in-makefile branch November 28, 2018 18:20
@kroening
Copy link
Member

I do find the names useful; please add to Travis/codebuild config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants