Don't clean and rename unused guard expression #3466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it was we tried to do renaming and simplification, only to bail because of the already-false state guard. That wasted time, and also generated false alarms when profiling calls to rename.
smowton
requested review from
kroening,
peterschrammel and
tautschnig
as code owners
tautschnig
approved these changes
Nov 26, 2018
allredj
reviewed
Nov 26, 2018
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 60d8a91).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/92566816
owen-mc-diffblue
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was we tried to do renaming and simplification, only to bail because of the already-false state guard. That wasted time, and also generated false alarms when profiling calls to rename.