Skip to content

smt2_solver: SMT2-specific message output #3440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2018
Merged

Conversation

kroening
Copy link
Member

errors get reported as (error "message"); any other output is marked as
comment.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

errors get reported as (error "message"); any other output is marked as
comment.
@kroening kroening force-pushed the smt2_diagnostic_output branch from f32ec43 to 9249423 Compare November 18, 2018 23:21
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 9249423).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/91801332

@tautschnig
Copy link
Collaborator

Why do changes to the error output have such a massive impact on the number of tests newly failing or passing?

@kroening
Copy link
Member Author

Positively since diagnostic output doesn't throw off the parser any longer; negatively since errors are no longer ignored.

@kroening kroening merged commit 1893fdb into develop Nov 24, 2018
@kroening kroening deleted the smt2_diagnostic_output branch November 24, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants