Refactoring in symex, replace nondet_count by a functor #3433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainbrenguier
requested review from
kroening,
peterschrammel and
tautschnig
as code owners
romainbrenguier
force-pushed
the
refactor/symex-nondet-count
branch
2 times, most recently
from
75a09b5 to
7bb258a
Compare
allredj
reviewed
Nov 16, 2018
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 7bb258a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/91660004
peterschrammel
approved these changes
Nov 16, 2018
| new_expr.add_source_location() = expr.source_location(); | ||
| expr.swap(new_expr); | ||
| } | ||
| else |
There was a problem hiding this comment.
Braces would be appreciated around a multiline block
This does not use any field and is not overriden.
This makes the information flow more obvious.
romainbrenguier
force-pushed
the
refactor/symex-nondet-count
branch
from
7bb258a to
8fb2902
Compare
allredj
reviewed
Nov 19, 2018
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 8fb2902).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/91839078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is clearer to have a functor that can only be used for generating symbols, than a counter.