Document remove asm #3405
Merged
Document remove asm #3405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danpoe
commented
Nov 13, 2018
danpoe
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
danpoe
requested review from
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
tautschnig
approved these changes
Nov 13, 2018
peterschrammel
approved these changes
Nov 13, 2018
src/goto-programs/remove_asm.cpp
Outdated
| /// Adds a call to a library function that implements the given gcc-style inline | ||
| /// assembly statement | ||
| /// | ||
| /// \param function_base_name: name of the function to call |
danpoe
force-pushed
the
docs/remove-asm
branch
from
39b69e8 to
900f66e
Compare
|
@danpoe, please fix the doxygen warnings. |
danpoe
force-pushed
the
docs/remove-asm
branch
from
900f66e to
6e05d99
Compare
allredj
reviewed
Nov 19, 2018
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 6e05d99).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/91903769
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.