[DOC-127]doc/cleanup-cprover-compilation-and-development #3384
Conversation
yumibagge
commented
Nov 13, 2018
yumibagge
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
Updated tag in link in the document from working-with-cmake-experiment to working-with-cmake.
In subsection "Running regression tests with ctest", build directory was not wrapped by ``. To make consistent expression with the rest of the document, it was changed from build to `build/`.
In subsection "Running regression tests directly with `test.pl`", for the first `test.pl`, it is not said `regression/test.pl` to clarify the location of the file.
In subsection "Unit tests", link was correct, but CODING_STANDARD.md was written in Compiling.md.
yumibagge
requested review from
chrisr-diffblue,
kroening,
peterschrammel,
smowton and
tautschnig
as code owners
|
I'm not sure why the Travis build has been cancelled? I have refrained from restarting it as presumably that was done intentionally. Either way, the CI failure is spurious, it just takes a restart or rebase. |
|
I believe @owen-jones-diffblue cancelled CI so to not waste time on Travis ... |
|
Yes, I cancelled them, as this only changes documentation, and I thought there might be updates which would make it run again. It's worth having a passing run before we merge, not least so I can click the merge button, so I've restarted the cancelled jobs. |
yumibagge
deleted the
doc/cleanup-cprover-compilation-and-development
branch
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 01dd28c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/91218254
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
