Add missing member initializers of string_constraintst-typed value [blocks: #2310] #3366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
martin-cs,
peterschrammel and
romainbrenguier
as code owners
allredj
reviewed
Nov 11, 2018
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 04b016b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90982543
| @@ -576,7 +576,7 @@ std::pair<exprt, string_constraintst> add_axioms_for_char_at( | |||
| array_string_exprt str = get_string_expr(array_pool, f.arguments()[0]); | |||
| symbol_exprt char_sym = fresh_symbol("char", str.type().subtype()); | |||
| const exprt constraint = equal_exprt(char_sym, str[f.arguments()[1]]); | |||
| return {char_sym, {{constraint}}}; | |||
| return {char_sym, {{constraint}, {}, {}}}; | |||
There was a problem hiding this comment.
This seems ok, but maybe a clearer solution would be to declare the string_constrainst explicitely:
string_constraintst constraints;
constraints.existential = equal_exprt(char_sym, str[f.arguments()[1]]);
return {char_sym, constraints};
to replace the last two lines.
romainbrenguier
approved these changes
Dec 4, 2018
add_axioms_for_char_at, add_axioms_for_is_empty, add_axioms_from_char only initialized one of the three vectors.
tautschnig
force-pushed
the
vs-member-init
branch
from
04b016b to
c078a69
Compare
allredj
reviewed
Dec 19, 2018
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: c078a69).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/95249315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_axioms_for_char_at, add_axioms_for_is_empty, add_axioms_from_char only
initialized one of the three vectors.
@romainbrenguier I am not entirely sure the modified initialisation code actually initialises the intended members.