-
Notifications
You must be signed in to change notification settings - Fork 274
simplify the remove_exceptions API #3288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} | ||
|
||
/// removes throws/CATCH-POP/CATCH-PUSH | ||
void remove_exceptions_and_instanceof( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name not really accurate; this should only affect the newly introduced instanceof instructions, not existing ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will flip naming around.
|
||
/// Removes 'throw x' and CATCH-PUSH/CATCH-POP | ||
/// and adds the required instrumentation (GOTOs and assignments) | ||
/// Any instanceof expressions are expanded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any new instanceof instructions
813c523
to
0cdc1f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 0cdc1f0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90551420
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removes the usage of a pointer an the potential to call the variant that does remove_instanceof without class hierarchy.
0cdc1f0
to
902cc69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 902cc69).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90679994
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
Please rebase to re-trigger the bot. |
I wouldn't bother - this needs a manual bump, I believe @allredj is looking at this. |
Marked do-not-merge and assigned to @allredj. |
Test-gen PR is here: https://github.com/diffblue/test-gen/pull/2457. Will notify when passing. |
TG bump passing. Good to merge. |
This removes the usage of a pointer an the potential to call the variant
that does remove_instanceof without class hierarchy.