Conps minisat [blocks: #3243] #3282
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to parse options again when setting up a solver, the parseOption method has to be present. Hence, link against the Options.cc file of MiniSat2 as well. Signed-off-by: Norbert Manthey <[email protected]>
CBMC compiles with more strict compiler warnings. To make the compiler happy, extend the MiniSat patch to fix the Option.cc file as well.
nmanthey
requested review from
chrisr-diffblue,
forejtv,
kroening,
martin-cs,
peterschrammel,
smowton,
tautschnig and
thk123
as code owners
martin-cs
requested changes
Nov 6, 2018
|
Closing as this has long been left and no progress appears imminent. Also see comments on #6088 related to these kinds of changes should this be reopened or re-attempted. Please reopen if you believe this has been closed erroneously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up for #3243 as the question for how to build CBMC with the conp-solutions minisat fork can be achieved.
This is WIP, because it has to be decided how/where to apply the changes. In case CBMC wants to move away from its MiniSat-patch approach, I might incorporate the solver changes to enable Werror again into my MiniSat fork.