Skip to content

Use new Doxygen script in Travis CI #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2018
Merged

Use new Doxygen script in Travis CI #3258

merged 2 commits into from
Nov 9, 2018

Conversation

johnnonweiler
Copy link
Contributor

@johnnonweiler johnnonweiler commented Nov 2, 2018 •
edited
Loading

The first commit here is from #3250 and the second is new. This changes .travis.yml to use the new script introduced by #3250, and removes the old travis_doxygen.sh script and associated part of
run_diff.sh.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@johnnonweiler
Copy link
Contributor Author

This should not be merged until the current problem with duplicate .md files is fixed.

@johnnonweiler
Copy link
Contributor Author

@thk123 It seems to be a very simple one line change to .travis.yml to use the new script. This PR (hopefully) tests that, and makes the future switch a simple case of pressing 'Merge'.

@johnnonweiler
Copy link
Contributor Author

johnnonweiler commented Nov 2, 2018 •
edited
Loading

I'm investigating the CI results from this PR. (The warnings related to assumptions.md were expected, but I don't know why there are other problems which I didn't see locally.)
Warnings related to assumptions.md in the CI results are the expected issue due to duplicate .md files.

@johnnonweiler
Copy link
Contributor Author

johnnonweiler commented Nov 6, 2018 •
edited
Loading

#3281 #3295 should fix the remaining remaining (assumptions.md) warnings.

peterschrammel added a commit that referenced this pull request Nov 8, 2018
@peterschrammel
Merge pull request #3295 from johnnonweiler/doc/exclude-cprover-manua…
f33dc9d 
…l-folder

Exclude doc/cprover-manual from Doxygen input [blocks: #3258]
John Nonweiler added 2 commits November 8, 2018 15:25
Use new Doxygen script in Travis CI
aee9bba 
Remove the old `travis_doxygen.sh` script and associated part of
`run_diff.sh`, and change `.travis.yml` to use the new `run_doxygen.sh`
instead.  The new script should report new problems (and not report
already existing problems) more reliably than the old script which
relied on the line numbers reported by Doxygen.
Update expected_doxygen_warnings.txt
a655ef9
@johnnonweiler
Copy link
Contributor Author

I've rebased and added a commit to update expected_doxygen_warnings.txt, with the new warnings which have been added (and the two which have been fixed 😃) since last week.

allredj
allredj reviewed Nov 8, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
Diffblue compatibility check is currently unavailable.
Please create manual bump.
(cbmc commit: a655ef9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90754733

@johnnonweiler johnnonweiler merged commit 43c84f8 into diffblue:develop Nov 9, 2018
@johnnonweiler johnnonweiler deleted the new-doxygen-ci-job branch November 9, 2018 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@peterschrammel peterschrammel peterschrammel approved these changes

@owen-mc-diffblue owen-mc-diffblue owen-mc-diffblue approved these changes

@forejtv forejtv Awaiting requested review from forejtv

@thk123 thk123 Awaiting requested review from thk123

Assignees

@thk123 thk123

@peterschrammel peterschrammel

@forejtv forejtv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@johnnonweiler @peterschrammel @allredj @owen-mc-diffblue @thk123 @tautschnig @forejtv @xbauch