copy_to_operands(exprt &&) -> add_to_operands #3254
Conversation
smowton
requested review from
kroening,
peterschrammel,
pkesseli and
tautschnig
as code owners
The current name means we end up writing `copy_to_operands(std::move(e))`, which looks like a mistake, since the whole point is it's a move, not a copy. Instead let's call it `add_to_operands` with overloads for copying or moving dependent on reference kind.
smowton
force-pushed
the
smowton/cleanup/add-to-operands
branch
from
9087e47 to
aea09dc
Compare
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 9087e47).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/89921426
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
|
I may have merged this too early, not giving Joel-bot a chance to comment |
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: aea09dc).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/89919628
|
@tautschnig it was fine -- it was because I amended the commit and the bot still tried to work off the old version. I'll ask Joel if he could easily re-check for the commit's existence before reporting |
|
Working on it! :-) |
The current name means we end up writing
copy_to_operands(std::move(e)), which looks like a mistake, since the whole point is it's a move, not a copy. Instead let's call itadd_to_operandswithoverloads for copying or moving dependent on reference kind.