Skip to content

move CPROVER manual source into git repo #3244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Conversation

kroening
Copy link
Member

@kroening kroening commented Oct 29, 2018

The CPROVER manual at http://www.cprover.org/cprover-manual/ is written
using markdown. The markdown sources are translated client-side into HTML.
This PR adds the markdown sources to the repo, which enables that they are
pulled directly from the git repo.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving of the overall approach. I have not actually reviewed the contents being added here, which may require some rework.

@kroening
Copy link
Member Author

@tautschnig The contents will definitively need work, but that should be separate.

The CPROVER manual at http://www.cprover.org/cprover-manual/ is written
using markdown.  The markdown sources are translated client-side into HTML.
This PR adds the markdown sources to the repo, which enables that they are
pulled directly from the git repo.
@kroening kroening force-pushed the cprover-manual-website branch from 633cd2e to 359d30e Compare October 29, 2018 14:47
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 633cd2e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/89525347
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 359d30e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/89527537

@kroening kroening merged commit f5b450f into develop Oct 29, 2018
@kroening kroening deleted the cprover-manual-website branch October 29, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants