Skip to content

Fix index expression in interpretert::evaluate #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Conversation

allredj
Copy link
Contributor

@allredj allredj commented Oct 23, 2018

Using integer2string here lead to a value having bad widths.

Sorry for the lack of regression test but I was not able to reproduce this using jbmc. There is however a test-gen regression test that catches the pre-existing bug.

This fixes a bug revealed (but not introduced) by #3100. The bug was only observed on test-gen.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Using integer2string here lead to a value having bad widths.
Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a reference to the commit which test exposed that? (To the TG commit if it was there).

Copy link
Contributor Author

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 46dbbd3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/88897648

@allredj allredj merged commit abeebfe into develop Oct 24, 2018
@allredj allredj deleted the fixup-PR3100 branch October 24, 2018 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants