Bugfix: store VCC counters per-path #3220
Merged
+79
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karkhaz
requested review from
kroening,
peterschrammel,
smowton and
tautschnig
as code owners
karkhaz
force-pushed
the
kk-bugfix-per-path-vcc-counters
branch
4 times, most recently
from
5d9b9c1 to
30424f7
Compare
allredj
reviewed
Oct 24, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: c013212).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/88959178
Prior to this commit, total_vccs and remaining_vccs had been members of goto_symext, meaning that they would be reset to zero every time a path was resumed. This would make CBMC incorrectly report safety for the included test program when running in path exploration mode, even though the program is reported as unsafe when CBMC runs in model-checking mode. This commit moves those members to goto_symex_statet, with goto_symext retaining cached versions so that its clients can read their values after the state has been torn down.
karkhaz
force-pushed
the
kk-bugfix-per-path-vcc-counters
branch
from
c013212 to
7a897a5
Compare
allredj
reviewed
Oct 25, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 7a897a5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/89136345
This was referenced Oct 25, 2018
tautschnig
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, total_vccs and remaining_vccs had been members of
goto_symext, meaning that they would be reset to zero every time a path
was resumed. This would make CBMC incorrectly report safety for the
included test program when running in path exploration mode, even though
the program is reported as unsafe when CBMC runs in model-checking mode.
This commit moves those members to goto_symex_statet, with goto_symext
retaining cached versions so that its clients can read their values
after the state has been torn down.