Skip to content

Do not duplicate what c_type_as_string takes care of #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

tautschnig
Copy link
Collaborator

With the exception of "bool", the type string output of the C front-end can be
used in the C++ front-end; the C front-end in turn uses c_type_as_string.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

With the exception of "bool", the type string output of the C front-end can be
used in the C++ front-end; the C front-end in turn uses c_type_as_string.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: f030b60).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87954055

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works. I know there are some differences between the two in terms of overloading vs. coercion but that should have all been resolved before we've got to this bit of code.

@tautschnig tautschnig merged commit 9a1cb1d into diffblue:develop Oct 22, 2018
@tautschnig tautschnig deleted the deduplicate-ID_C_c_type branch October 22, 2018 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants