mstreamt manipulators are now static #3166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Oct 14, 2018
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- My contribution is formatted in line with CODING_STANDARD.md.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
kroening
requested review from
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
7 tasks
tautschnig
reviewed
Oct 14, 2018
src/util/message.h
Outdated
| static_cast<std::ostream &>(m) << std::endl; | ||
| return m; | ||
| public: | ||
| commandt(unsigned _command) : command(_command) |
There was a problem hiding this comment.
Missing explicit - unless that omission was intentional, in which case I'd wonder even more whether a typedef might just be good enough.
kroening
force-pushed
the
mstream-manipulators
branch
from
d44777d to
e510f52
Compare
added 2 commits
October 14, 2018 21:09
This matches what clang/gcc's STL implementations do; the key benefit is that the methods/members for the manipulators can now be static.
kroening
force-pushed
the
mstream-manipulators
branch
from
e510f52 to
5095eab
Compare
tautschnig
approved these changes
Oct 14, 2018
allredj
reviewed
Oct 14, 2018
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 90b04e3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87894852
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
martin-cs
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.