Functions for outputting options #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

peterschrammel merged 3 commits into diffblue:develop from peterschrammel:output-options

Oct 23, 2018

Member

peterschrammel commented Oct 9, 2018 •

edited

Loading

This can be used to output the options set at the beginning
of an analysis in order to understand the settings.

Each commit message has a non-empty body, explaining why the change was made.
My contribution is formatted in line with CODING_STANDARD.md.
Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
My commit message includes data points confirming performance improvements (if claimed).
My PR is restricted to a single feature or bugfix.
White-space or formatting changes outside the feature-related changed lines are in commits of their own.

peterschrammel requested review from kroening, pkesseli, smowton and tautschnig as code owners

October 9, 2018 16:57

Contributor

smowton commented Oct 9, 2018

Should probably add a simple user / test at the same time?

Collaborator

martin-cs commented Oct 9, 2018

FWIW I'm planning on not only doing this but also dumping a check sum of the analyzer binary and the input goto-program to help make the chain of reproducibility as strong as possible.

So, +1, sounds good to me.

peterschrammel force-pushed the output-options branch from 9caa6b9 to f11668b Compare

October 9, 2018 20:59

peterschrammel requested review from cesaro and cristina-david as code owners

October 9, 2018 20:59

Member Author

peterschrammel commented Oct 9, 2018

Added XML support and JBMC as example user.

allredj reviewed

View reviewed changes

Contributor

allredj left a comment

Passed Diffblue compatibility checks (cbmc commit: f11668b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87405251

Contributor

smowton commented Oct 10, 2018

Great, now it's easy to add a simple regression test ;)

tautschnig approved these changes

View reviewed changes

jbmc/src/jbmc/jbmc_parse_options.cpp Outdated

+                switch(ui_message_handler.get_ui())
+                {
+                  case ui_message_handlert::uit::PLAIN:
+                    options.output(debug());

Collaborator

tautschnig Oct 15, 2018

I believe you could use conditional_output(debug(), options.output);

tautschnig assigned peterschrammel

peterschrammel added 2 commits

October 21, 2018 22:17


          Functions for outputting options

32d4973

This can be used to output the options set at the beginning
of an analysis in order to understand the settings.


          Evaluate verbosity before producing output

5741a43

peterschrammel force-pushed the output-options branch from f11668b to 7752db3 Compare

October 21, 2018 21:39

Member Author

peterschrammel commented Oct 21, 2018

@smowton, added.

Collaborator

tautschnig commented Oct 22, 2018

@peterschrammel: That newly added test is failing, it seems the options are not actually printed.

4 similar comments

Collaborator

tautschnig commented Oct 22, 2018

@peterschrammel: That newly added test is failing, it seems the options are not actually printed.

Collaborator

tautschnig commented Oct 22, 2018

@peterschrammel: That newly added test is failing, it seems the options are not actually printed.

Collaborator

tautschnig commented Oct 22, 2018

@peterschrammel: That newly added test is failing, it seems the options are not actually printed.

Collaborator

tautschnig commented Oct 22, 2018

@peterschrammel: That newly added test is failing, it seems the options are not actually printed.

peterschrammel force-pushed the output-options branch from 7752db3 to a292737 Compare

October 22, 2018 08:27

smowton approved these changes

View reviewed changes

Collaborator

tautschnig commented Oct 22, 2018

@peterschrammel: That newly added test is failing, it seems the options are not actually printed.

1 similar comment

Collaborator

tautschnig commented Oct 22, 2018

@peterschrammel: That newly added test is failing, it seems the options are not actually printed.


          Output options in JBMC

5b8d9a3

allredj reviewed

View reviewed changes

Contributor

allredj left a comment

Passed Diffblue compatibility checks (cbmc commit: 5b8d9a3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/88728095

peterschrammel merged commit 084fc14 into diffblue:develop

peterschrammel deleted the output-options branch

October 23, 2018 09:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

allredj allredj left review comments

smowton smowton approved these changes

tautschnig tautschnig approved these changes

kroening Awaiting requested review from kroening kroening is a code owner

pkesseli Awaiting requested review from pkesseli

cesaro Awaiting requested review from cesaro

cristina-david Awaiting requested review from cristina-david

Labels

None yet