Program table symbol type consistency #3128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xbauch
requested review from
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
added 2 commits
October 9, 2018 13:46
This first commit is just PR diffblue#3118 to reuse the common structure of checking this kind of consistency.
Look up the symbol id in symbol table and call base_type_eq on every symbol expression in guard and code whenever relevant. Print out all inconsistencies.
xbauch
force-pushed
the
program_table_symbol_type_consistency
branch
from
c5ee238 to
40f038a
Compare
…e#3123 The condition to be checked is the same. Interface function name was changed to follow the above PR. Also the check is now optional via command line.
7 tasks
Builds a goto program with one assertion and checks that: 1) with the right type in the table the validation succeeds, 2) with the wrong type the validation fails.
allredj
reviewed
Oct 11, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 786e3b8).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87658951
|
Moved to #3118. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is just PR #3118 to reuse the common structure of checking this kind of consistency. The second looks up the symbol id in symbol table and calls base_type_eq on every symbol
expression in guard and code whenever relevant. Then prints out all inconsistencies.