Remove the __CPROVER_HIDE label when inlining #3125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving this label in place will mark the function being inlined into as hidden,
which messes up, e.g., coverage instrumentation.
Consider hidden.c:
#include <string.h>
int foo() { char *a, *b; return memcmp(a, b, 1); }
int main() { foo(); return 0; }
goto-cc hidden.c
goto-instrument --add-library a.out b.out (add library function with hiding)
goto-analyzer --simplify c.out b.out (goto-analyzer does inlining)
cbmc --cover location c.out (will be missing any coverage targets in foo)
cbmc --cover location b.out (has coverage targets in foo)
With this patch, cbmc --cover location c.out also has coverage targets in foo.