Skip to content

Remove the __CPROVER_HIDE label when inlining #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

tautschnig
Copy link
Collaborator

Leaving this label in place will mark the function being inlined into as hidden,
which messes up, e.g., coverage instrumentation.

Consider hidden.c:

#include <string.h>
int foo() { char *a, *b; return memcmp(a, b, 1); }
int main() { foo(); return 0; }

goto-cc hidden.c
goto-instrument --add-library a.out b.out (add library function with hiding)
goto-analyzer --simplify c.out b.out (goto-analyzer does inlining)
cbmc --cover location c.out (will be missing any coverage targets in foo)
cbmc --cover location b.out (has coverage targets in foo)

With this patch, cbmc --cover location c.out also has coverage targets in foo.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Leaving this label in place will mark the function being inlined into as hidden,
which messes up, e.g., coverage instrumentation.

Consider hidden.c:

 #include <string.h>
 int foo() { char *a, *b; return memcmp(a, b, 1); }
 int main() { foo(); return 0; }

goto-cc hidden.c
goto-instrument --add-library a.out b.out (add library function with hiding)
goto-analyzer --simplify c.out b.out (goto-analyzer does inlining)
cbmc --cover location c.out (will be missing any coverage targets in foo)
cbmc --cover location b.out (has coverage targets in foo)

With this patch, cbmc --cover location c.out also has coverage targets in foo.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR failed Diffblue compatibility checks (cbmc commit: f2306e3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87246538
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: f2306e3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87246538

@tautschnig tautschnig merged commit 4d2905f into diffblue:develop Oct 9, 2018
@tautschnig tautschnig deleted the fix-hiding branch October 9, 2018 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants