Skip to content

Cleanup irep serialization #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 8, 2018

Conversation

tautschnig
Copy link
Collaborator

While debugging an irep-serialization-related problem (PR to follow) I noticed a couple of places that could do with some cleanup. No changes in behaviour, though minor performance improvements are possible.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Comments were incomplete and did not cleanly refer to parameters.
Make sure we don't attempt to read beyond the end of a broken file.
This is only useful and used in exactly one place, and its comment was adamant
that it must not be used in a different context.
There was only a single use, with a prior comment already suggesting that a
redunant lookup could be avoided.
Avoids duplicating the same statement.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR failed Diffblue compatibility checks (cbmc commit: 2150648).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87185311
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

@peterschrammel peterschrammel removed their assignment Oct 8, 2018
@tautschnig tautschnig merged commit 4ef3dc5 into diffblue:develop Oct 8, 2018
@tautschnig tautschnig deleted the cleanup-irep-serialization branch October 8, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants