Skip to content

boolbvt::convert_constant is now independent of bitvector representation #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2018
Merged

boolbvt::convert_constant is now independent of bitvector representation #3106

merged 2 commits into from
Oct 7, 2018

Conversation

kroening
Copy link
Member

@kroening kroening commented Oct 6, 2018 •
edited
Loading

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

tautschnig
tautschnig reviewed Oct 6, 2018
View reviewed changes
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is benefit of this at this time as it is certainly incomplete (just scrolling a few lines up shows another case where the binary string is used directly)? My bigger concern is performance - we will do this particular conversion a lot, and the only saviour might be caching?

allredj
allredj reviewed Oct 6, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR failed Diffblue compatibility checks (cbmc commit: 81e2c26).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87102225
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

allredj
allredj reviewed Oct 6, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 6dfb412).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87102618

@kroening
Copy link
Member Author

kroening commented Oct 6, 2018

Ok, new approach -- this one avoids going through mp_integer.

allredj
allredj reviewed Oct 6, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: e2f2c22).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87109398

allredj
allredj reviewed Oct 7, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 9ade5b4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87123885

tautschnig
tautschnig reviewed Oct 7, 2018
View reviewed changes
src/util/arith_tools.h Outdated
@@ -164,4 +164,9 @@ mp_integer power(const mp_integer &base, const mp_integer &exponent);
void mp_min(mp_integer &a, const mp_integer &b);
void mp_max(mp_integer &a, const mp_integer &b);

/// get bit with given index from bit vector
/// \param src: the bitvector representation
/// \param bit_index: the index (0 is the least significant)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I don't usually complain about too much documentation, but I'm worried about inconsistencies if we document twice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@kroening kroening mentioned this pull request Oct 7, 2018
Merged
7 tasks
@kroening kroening assigned tautschnig and unassigned kroening Oct 7, 2018
allredj
allredj reviewed Oct 7, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 2313911).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87130961

@kroening kroening merged commit f0ec760 into develop Oct 7, 2018
@kroening kroening deleted the hex-bitvectors7 branch October 7, 2018 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@tautschnig tautschnig tautschnig approved these changes

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@smowton smowton Awaiting requested review from smowton

Assignees

@tautschnig tautschnig

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kroening @tautschnig @allredj