Clean up replace_symbolt interface #3101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add set(), with meaning similar to insert() but overwriting any existing value, and an overload of erase() that takes an iterator. These allow the constant propagator to use it more cleanly (though not entirely; it still needs get_expr_map() for some tasks such as merging two replace_symbolt objects). No behavioural change is intended here.
smowton
requested review from
chrisr-diffblue,
kroening,
martin-cs,
peterschrammel,
pkesseli,
tautschnig and
thk123
as code owners
allredj
reviewed
Oct 5, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: c2143d0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86983957
tautschnig
approved these changes
Oct 5, 2018
peterschrammel
approved these changes
Oct 6, 2018
| expr_map[old_expr.get_identifier()] = new_expr; | ||
| } | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add set(), with meaning similar to insert() but overwriting any existing value, and
an overload of erase() that takes an iterator. These allow the constant propagator to use
it more cleanly (though not entirely; it still needs get_expr_map() for some tasks such
as merging two replace_symbolt objects).
No behavioural change is intended here.
Doing this partial cleanup because the security product's out-of-tree changes required us to intercept some operations that the constant propagator directly executed against
expr_map; these cleanups bring the two versions closer together, and are hopefully code quality improvements regardless.- [ ] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).- [ ] My commit message includes data points confirming performance improvements (if claimed).