Skip to content

introduce integer2bv and bv2integer #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2018
Merged

introduce integer2bv and bv2integer #3096

merged 1 commit into from
Oct 4, 2018

Conversation

kroening
Copy link
Member

@kroening kroening commented Oct 4, 2018

The representation of bitvectors is now hard-wired to binary with leading
zeros and fixed width. These two new functions provide a wrapper around any
future representation.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 5d379b0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86870089

Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tautschnig
Copy link
Collaborator

This needs a rebase now that #3098 is in (its CI run completed first...).

The representation of bitvectors is now hard-wired to binary with leading
zeros and fixed width.  These two new functions provide a wrapper around any
future representation.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR failed Diffblue compatibility checks (cbmc commit: 430400b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86893200
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

@kroening kroening merged commit 35ee875 into develop Oct 4, 2018
@kroening kroening deleted the hex-bitvectors branch October 4, 2018 16:40
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 935f4d2).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86910233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants