-
Notifications
You must be signed in to change notification settings - Fork 274
Use constructors to construct objects #3075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2dc37a8
to
11d34d3
Compare
11d34d3
to
0ee10a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One simple improvement given the code-function-callt-with-dummy-first-argument pattern occurs a few times (though perhaps this would introduce an ambiguous first constructor?) Also as noted in the other PR, I'd prefer if move-to-operands -> add was not pessimised.
jbmc/src/java_bytecode/java_bytecode_concurrency_instrumentation.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: 11d34d3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86479380
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Diffblue compatibility checks (cbmc commit: 0ee10a4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86484504
0ee10a4
to
d5cdcd8
Compare
This is some drive-by cleanup resulting from reviewing diffblue#3067. Instead of incrementally constructing objects do RAII.
d5cdcd8
to
dbc5439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Diffblue compatibility checks (cbmc commit: dbc5439).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86678835
This is some drive-by cleanup resulting from reviewing #3067. Instead of
incrementally constructing objects do RAII.