Skip to content

Use constructors to construct objects #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2018

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Oct 1, 2018

This is some drive-by cleanup resulting from reviewing #3067. Instead of
incrementally constructing objects do RAII.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • [n/a] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [n/a] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • [n/a] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening removed their assignment Oct 1, 2018
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One simple improvement given the code-function-callt-with-dummy-first-argument pattern occurs a few times (though perhaps this would introduce an ambiguous first constructor?) Also as noted in the other PR, I'd prefer if move-to-operands -> add was not pessimised.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR failed Diffblue compatibility checks (cbmc commit: 11d34d3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86479380
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 0ee10a4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86484504

This is some drive-by cleanup resulting from reviewing diffblue#3067. Instead of
incrementally constructing objects do RAII.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: dbc5439).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86678835

@peterschrammel peterschrammel removed their assignment Oct 6, 2018
@tautschnig tautschnig merged commit 3ee1309 into diffblue:develop Oct 7, 2018
@tautschnig tautschnig deleted the drive-by-cleanup branch October 7, 2018 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants