Skip to content

Make regression test pass when sizeof(size_t) == sizeof(int) #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

tautschnig
Copy link
Collaborator

The type cast previously tested for in the regression test will only be
introduced when the type of an array index is not the same as int. Thus the test
spuriously failed on 32-bit x86 platforms.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • [n/a] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [n/a] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • [n/a] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The type cast previously tested for in the regression test will only be
introduced when the type of an array index is not the same as int. Thus the test
spuriously failed on 32-bit x86 platforms.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 6620cdb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86427120

@kroening kroening merged commit aca054f into diffblue:develop Oct 1, 2018
@tautschnig tautschnig deleted the 32bit branch October 1, 2018 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants