Use numeric_cast_v<std::size_t> instead of deprecated integer2size_t [blocks: #2310] #3051

tautschnig · 2018-09-26T12:00:41Z

Each commit message has a non-empty body, explaining why the change was made.
My contribution is formatted in line with CODING_STANDARD.md.
n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
n/a My commit message includes data points confirming performance improvements (if claimed).
My PR is restricted to a single feature or bugfix.
White-space or formatting changes outside the feature-related changed lines are in commits of their own.

tautschnig · 2018-09-26T13:09:31Z

~~I will revisit this once #3047 is merged (they have conflicting/duplicating changes).~~

kroening · 2018-10-04T17:15:23Z

src/goto-programs/goto_convert.cpp

@@ -1903,7 +1903,7 @@ bool goto_convertt::get_string_constant(
      forall_operands(it, index_op)
        if(it->is_constant())
        {
-          unsigned long i=integer2ulong(
+          const std::size_t i = numeric_cast_v<std::size_t>(
            binary2integer(id2string(to_constant_expr(*it).get_value()), true));



BTW, just ran into that one again (in #3100).

I'd advocate removing this method, given that I don't think it works.

Which method are you referring to? I wasn't able to figure out which problem #3100 is solving, so I'd need more info. Thanks!

allredj

This PR failed Diffblue compatibility checks (cbmc commit: fd61169).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87937825
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

the cbmc commit has disappeared in the mean time (e.g. in a force-push)
the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

allredj

Passed Diffblue compatibility checks (cbmc commit: 9cd404b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87938549

martin-cs

This change appears to be as described in all the areas I am "owner" of.

allredj

Passed Diffblue compatibility checks (cbmc commit: d73108e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/88736803

allredj

✔️
Passed Diffblue compatibility checks (cbmc commit: 23ff9c9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/89875998

allredj

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 7a4c5e1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90159583
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

the cbmc commit has disappeared in the mean time (e.g. in a force-push)
the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

martin-cs · 2018-11-06T13:59:45Z

How does this relate to #3252 ? Should this be updated / closed in light of that?

tautschnig · 2018-11-06T22:41:22Z

How does this relate to #3252 ? Should this be updated / closed in light of that?

No, they refer to two different types being converted to: this one is for std::size_t, #3252 was mp_integer.

allredj

✔️
Passed Diffblue compatibility checks (cbmc commit: 5d837c0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90496251

allredj

🚫
This PR failed Diffblue compatibility checks (cbmc commit: eca50ce).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90620816
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

the cbmc commit has disappeared in the mean time (e.g. in a force-push)
the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

integer2size_t is deprecated. Replacing it as recommended reduces the number of warnings emitted at build time and actually implements what deprecation is about.

allredj

⚠️
Diffblue compatibility check is currently unavailable.
Please create manual bump.
(cbmc commit: fe3f73c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90844662

romainbrenguier · 2018-11-09T12:25:37Z

Check actually passed ✔️

tautschnig requested review from cesaro, chrisr-diffblue, cristina-david, kroening, martin-cs, mgudemann, NathanJPhillips, peterschrammel, pkesseli, smowton and thk123 as code owners September 26, 2018 12:00

tautschnig self-assigned this Sep 26, 2018

kroening reviewed Oct 4, 2018

View reviewed changes

tautschnig force-pushed the integer2size_t branch 2 times, most recently from fd61169 to 9cd404b Compare October 15, 2018 09:55

tautschnig assigned smowton, kroening and peterschrammel and unassigned tautschnig Oct 15, 2018

allredj reviewed Oct 15, 2018

View reviewed changes

martin-cs approved these changes Oct 15, 2018

View reviewed changes

smowton approved these changes Oct 17, 2018

View reviewed changes

tautschnig unassigned smowton and peterschrammel Oct 17, 2018

tautschnig force-pushed the integer2size_t branch from 9cd404b to d73108e Compare October 22, 2018 11:33

allredj reviewed Oct 22, 2018

View reviewed changes

tautschnig force-pushed the integer2size_t branch 2 times, most recently from be727b4 to 23ff9c9 Compare October 31, 2018 20:39

allredj reviewed Oct 31, 2018

View reviewed changes

tautschnig force-pushed the integer2size_t branch from 23ff9c9 to 7a4c5e1 Compare November 3, 2018 11:33

allredj reviewed Nov 3, 2018

View reviewed changes

tautschnig force-pushed the integer2size_t branch from 7a4c5e1 to 5d837c0 Compare November 6, 2018 22:44

allredj reviewed Nov 7, 2018

View reviewed changes

tautschnig changed the title ~~Use numeric_cast_v<std::size_t> instead of deprecated integer2size_t~~ Use numeric_cast_v<std::size_t> instead of deprecated integer2size_t [blocks: #2310] Nov 7, 2018

tautschnig added the blocker label Nov 7, 2018

kroening added the Needs rebase label Nov 7, 2018

kroening approved these changes Nov 7, 2018

View reviewed changes

kroening assigned tautschnig and unassigned kroening Nov 7, 2018

tautschnig force-pushed the integer2size_t branch from 5d837c0 to eca50ce Compare November 7, 2018 19:09

tautschnig removed the Needs rebase label Nov 7, 2018

allredj reviewed Nov 7, 2018

View reviewed changes

Use numeric_cast_v<std::size_t> instead of integer2size_t

fe3f73c

integer2size_t is deprecated. Replacing it as recommended reduces the number of warnings emitted at build time and actually implements what deprecation is about.

tautschnig force-pushed the integer2size_t branch from eca50ce to fe3f73c Compare November 9, 2018 10:26

allredj reviewed Nov 9, 2018

View reviewed changes

tautschnig merged commit 59f9e73 into diffblue:develop Nov 9, 2018

tautschnig deleted the integer2size_t branch November 9, 2018 12:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use numeric_cast_v<std::size_t> instead of deprecated integer2size_t [blocks: #2310] #3051

Use numeric_cast_v<std::size_t> instead of deprecated integer2size_t [blocks: #2310] #3051

Uh oh!

tautschnig commented Sep 26, 2018 •

edited

Loading

Uh oh!

tautschnig commented Sep 26, 2018 •

edited

Loading

Uh oh!

kroening Oct 4, 2018

Uh oh!

tautschnig Oct 5, 2018

Uh oh!

allredj left a comment

Uh oh!

allredj left a comment

Uh oh!

martin-cs left a comment

Uh oh!

allredj left a comment

Uh oh!

allredj left a comment

Uh oh!

allredj left a comment

Uh oh!

martin-cs commented Nov 6, 2018

Uh oh!

tautschnig commented Nov 6, 2018

Uh oh!

allredj left a comment

Uh oh!

allredj left a comment

Uh oh!

allredj left a comment

Uh oh!

romainbrenguier commented Nov 9, 2018

Uh oh!

Uh oh!

Use numeric_cast_v<std::size_t> instead of deprecated integer2size_t [blocks: #2310] #3051

Use numeric_cast_v<std::size_t> instead of deprecated integer2size_t [blocks: #2310] #3051

Uh oh!

Conversation

tautschnig commented Sep 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tautschnig commented Sep 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kroening Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

tautschnig Oct 5, 2018

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

martin-cs left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

martin-cs commented Nov 6, 2018

Uh oh!

tautschnig commented Nov 6, 2018

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

romainbrenguier commented Nov 9, 2018

Uh oh!

Uh oh!

tautschnig commented Sep 26, 2018 •

edited

Loading

tautschnig commented Sep 26, 2018 •

edited

Loading