Skip to content

Remove unused quantifier_exprt default constructor #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

tautschnig
Copy link
Collaborator

It made use of the deprecated symbol_exprt() constructor and was never used
anyway.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't get a test-gen compile failure

It made use of the deprecated symbol_exprt() constructor and was only used by
the otherwise unused exists/forall default constructors.
@tautschnig tautschnig force-pushed the quantifier_exprt-cleanup branch from 91d64fb to 7ff7c27 Compare September 26, 2018 10:27
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 7ff7c27).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85998882

@tautschnig tautschnig merged commit 01a348c into diffblue:develop Sep 26, 2018
@tautschnig tautschnig deleted the quantifier_exprt-cleanup branch September 26, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants