Skip to content

miniz: silence warnings #3034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2018
Merged

miniz: silence warnings #3034

merged 1 commit into from
Sep 26, 2018

Conversation

tautschnig
Copy link
Collaborator

This is third-party code.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Sep 24, 2018
@tautschnig tautschnig force-pushed the miniz-warnings branch 2 times, most recently from 20a0f8d to 00fedc5 Compare September 26, 2018 06:23
allredj
allredj reviewed Sep 26, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 00fedc5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85961450

smowton
smowton reviewed Sep 26, 2018
View reviewed changes
@tautschnig
miniz: silence warnings
1f48810 
This is third-party code.
@tautschnig tautschnig merged commit ed4637b into diffblue:develop Sep 26, 2018
@tautschnig tautschnig deleted the miniz-warnings branch September 26, 2018 11:05
allredj
allredj reviewed Sep 26, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 1f48810).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85988754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@cesaro cesaro Awaiting requested review from cesaro

@cristina-david cristina-david Awaiting requested review from cristina-david

@mgudemann mgudemann Awaiting requested review from mgudemann

@NathanJPhillips NathanJPhillips Awaiting requested review from NathanJPhillips

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@thk123 thk123 Awaiting requested review from thk123

Assignees

@smowton smowton

@mgudemann mgudemann

@peterschrammel peterschrammel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tautschnig @smowton @allredj @mgudemann @peterschrammel