Use ranged for to iterate over components #3033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
cesaro,
chrisr-diffblue,
cristina-david,
kroening,
martin-cs,
mgudemann,
NathanJPhillips,
peterschrammel,
pkesseli,
smowton and
thk123
as code owners
tautschnig
force-pushed
the
more-ranged-for
branch
from
2f79681 to
b91fd0a
Compare
tautschnig
changed the title
smowton
approved these changes
Sep 24, 2018
src/goto-instrument/dump_c.cpp
Outdated
| it=old_components.begin(); | ||
| it!=old_components.end(); | ||
| ++it) | ||
| for(const auto &c : old_components) |
There was a problem hiding this comment.
Suggest c -> old_comp to more clearly distinguish it from the also-in-scope comp
tautschnig
force-pushed
the
more-ranged-for
branch
from
b91fd0a to
0fa49ca
Compare
Follow-up work to 716279f (now no longer restricted to the cpp folder), making the code easier to read.
tautschnig
force-pushed
the
more-ranged-for
branch
from
0fa49ca to
cde5ac3
Compare
allredj
reviewed
Sep 24, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: cde5ac3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85757683
kroening
approved these changes
Sep 24, 2018
peterschrammel
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up work to 716279f (now no longer
restricted to the cpp folder), making the code easier to read.