Skip to content

Use cpp_namet's and namet's constructors #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

tautschnig
Copy link
Collaborator

Constructing the underlying irept manually is error-prone. Also don't
reduandantly assert that a cpp_namet has id() == ID_cpp_name.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Constructing the underlying irept manually is error-prone. Also don't
reduandantly assert that a cpp_namet has id() == ID_cpp_name.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 7f817ca).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85718212

@peterschrammel peterschrammel removed their assignment Sep 24, 2018
@tautschnig tautschnig merged commit 45f469d into diffblue:develop Sep 24, 2018
@tautschnig tautschnig deleted the cpp_namet branch September 24, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants