goto-analyzer: default result report now uses messaget #3022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
chrisr-diffblue,
martin-cs and
peterschrammel
as code owners
kroening
force-pushed
the
goto-analyzer-use-messaget
branch
from
d703c21 to
e8e0cff
Compare
allredj
reviewed
Sep 23, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: e8e0cff).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85660560
tautschnig
reviewed
Sep 24, 2018
| std::ofstream output_stream; | ||
| if(!(outfile=="-")) | ||
| if(outfile != "-" && outfile != "") |
There was a problem hiding this comment.
I'd use !outfile.empty()
| output_stream.open(outfile); | ||
|
|
||
| std::ostream &out((outfile=="-") ? std::cout : output_stream); | ||
| std::ostream &out( | ||
| (outfile == "-" || outfile == "") ? std::cout : output_stream); |
peterschrammel
approved these changes
Sep 24, 2018
Splitting 'report into text file' and 'report onto console' enables tweaking the latter, e.g., by adding colors.
kroening
force-pushed
the
goto-analyzer-use-messaget
branch
from
e8e0cff to
2c19624
Compare
allredj
reviewed
Sep 25, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 2c19624).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85832591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting 'report into text file' and 'report onto console' enables tweaking
the latter, e.g., by adding colors.