API change: from_integer for negative naturals #3016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
peterschrammel,
pkesseli and
smowton
as code owners
tautschnig
approved these changes
Sep 21, 2018
src/util/arith_tools.cpp
Outdated
| } | ||
| else if(type_id==ID_pointer) | ||
| { | ||
| if(int_value==0) | ||
| return null_pointer_exprt(to_pointer_type(type)); | ||
| else | ||
| PRECONDITION(false); |
There was a problem hiding this comment.
I think this should be written as
PRECONDITION(int_value == 0);
return null_pointer_exprt(to_pointer_type(type));
src/util/arith_tools.cpp
Outdated
| @@ -158,11 +152,15 @@ constant_exprt from_integer( | |||
| return false_exprt(); | |||
| else if(int_value==1) | |||
| return true_exprt(); | |||
| else | |||
| PRECONDITION(false); | |||
There was a problem hiding this comment.
I'd do:
PRECONDITION(int_value == 0 || int_value == 1);
if(int_value == 0)
return false_exprt();
else
return true_exprt();
This changes behavior for the case that from_integer is asked to produce a natural number that is negative. Previously, a malformed constant_exprt with nil id was returned; now a precondition fails.
kroening
force-pushed
the
from_integer_negative_natural
branch
from
a53b7a5 to
92eab68
Compare
allredj
reviewed
Sep 21, 2018
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: a53b7a5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85596705
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
allredj
reviewed
Sep 21, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 92eab68).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85599486
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes behavior for the case that from_integer is asked to produce a
natural number that is negative. Previously, a malformed constant_exprt
with nil id was returned; now a precondition fails.