Skip to content

Do not unnecessarily set ID_base_name #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

tautschnig
Copy link
Collaborator

The value was set, but never read.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The value was set, but never read.
@smowton
Copy link
Contributor

smowton commented Sep 21, 2018

@thk123 any usage in TG?

@tautschnig
Copy link
Collaborator Author

@thk123 any usage in TG?

In case there is: class_type.get_tag() would yield the same value, and would thus be the change required if this were to be merged.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 93c0c65).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85561530

@thk123
Copy link
Contributor

thk123 commented Sep 21, 2018

Nope - no usages of ID_base_name in TG 👍

@kroening kroening merged commit 0e98e1d into diffblue:develop Sep 21, 2018
@tautschnig tautschnig deleted the no-base-name branch September 22, 2018 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants