Skip to content

Move is_class and default_access to struct_union_typet #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

tautschnig
Copy link
Collaborator

A class_typet would always return true for is_class() and ID_private for
default_access(). Only when available for both a struct_typet and a
class_typet do they enable non-trivial use.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

A class_typet would always return true for is_class() and ID_private for
default_access(). Only when available struct_typet, union_typet, and
class_typet do they enable non-trivial use.
@tautschnig tautschnig changed the title Move is_class and default_access to struct_typet Move is_class and default_access to struct_union_typet Sep 21, 2018
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR failed Diffblue compatibility checks (cbmc commit: 15b43ae).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85541410
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: cf07c6c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85542675

@kroening kroening merged commit 9864a22 into diffblue:develop Sep 21, 2018
@tautschnig tautschnig deleted the struct-class branch September 22, 2018 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants