Skip to content

better location for compound members #2997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2018
Merged

better location for compound members #2997

merged 1 commit into from
Sep 29, 2018

Conversation

kroening
Copy link
Member

@kroening kroening commented Sep 19, 2018 •
edited
Loading

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening requested a review from tautschnig September 19, 2018 16:39
allredj
allredj reviewed Sep 19, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: cdc5437).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85338834

@kroening kroening assigned tautschnig and unassigned kroening Sep 28, 2018
allredj
allredj reviewed Sep 29, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 0f43b25).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86350903

@tautschnig tautschnig merged commit 2e84af4 into develop Sep 29, 2018
@tautschnig tautschnig deleted the member-location branch September 29, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@tautschnig tautschnig tautschnig approved these changes

Assignees

@tautschnig tautschnig

Labels
C Front End enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kroening @tautschnig @allredj