Skip to content

Do not use outdated *-mod.gb file #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Sep 18, 2018

The regression test wrapper scripts perform a conditional copy of the goto
binary, which is meant to cover the case that an invocation of goto-instrument
does not generate a goto binary. When regression tests are re-run without an
intermittent "clean", the conditional copy was not performed. This may lead to
spurious test failures when goto binary versions change.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The regression test wrapper scripts perform a conditional copy of the goto
binary, which is meant to cover the case that an invocation of goto-instrument
does not generate a goto binary. When regression tests are re-run without an
intermittent "clean", the conditional copy was not performed. This may lead to
spurious test failures when goto binary versions change.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 545ad66).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85206668

@kroening kroening merged commit cb20b95 into diffblue:develop Sep 18, 2018
@tautschnig tautschnig deleted the regression-fix branch September 19, 2018 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants